Skip to content

[v22.x] vm: expose import attributes on SourceTextModule.moduleRequests #59962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
legendecas wants to merge 1 commit into from
Closed

[v22.x] vm: expose import attributes on SourceTextModule.moduleRequests #59962

legendecas wants to merge 1 commit into from

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Sep 21, 2025

Expose import attributes on vm.SourceTextModule.moduleRequests. This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

PR-URL: #58829
Refs: #37648
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Marco Ippolito [email protected]

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2025

Review requested:

  • @nodejs/loaders
  • @nodejs/vm
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. vm Issues and PRs related to the vm subsystem. labels Sep 21, 2025
@legendecas legendecas mentioned this pull request Sep 21, 2025
Merged
@legendecas legendecas changed the title vm: expose import attributes on SourceTextModule.moduleRequests [v22.x] vm: expose import attributes on SourceTextModule.moduleRequests Sep 21, 2025
@richardlau
Copy link
Member

richardlau commented Sep 21, 2025

This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

Shouldn't that have been added to doc/api/deprecations.md on main?

@legendecas
Copy link
Member Author

legendecas commented Sep 21, 2025

This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

Shouldn't that have been added to doc/api/deprecations.md on main?

It is not required to go through deprecation cycle for an experimental API. To fully remove dependencySpecifiers, we will need vm.SourceTextModule.moduleRequests available on all LTS lines first (this PR backports it).

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69313/

richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas @richardlau
vm: expose import attributes on SourceTextModule.moduleRequests
9807ffd 
PR-URL: #58829
Backport-PR-URL: #59962
Refs: #37648
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@richardlau
Copy link
Member

richardlau commented Sep 22, 2025

Landed in 9807ffd

@richardlau richardlau closed this Sep 22, 2025
@legendecas legendecas deleted the backport-58829-to-22 branch September 23, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas @nodejs-github-bot @richardlau