test: ensure assertions are reached on more tests #60641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60641 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01%
==========================================
Files 703 703
Lines 208077 208077
Branches 40083 40080 -3
==========================================
+ Hits 184214 184251 +37
+ Misses 15881 15856 -25
+ Partials 7982 7970 -12 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 9, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Nov 11, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f1f6f3d |
github-project-automation
bot
moved this from Need Triage
to Done
in Node-API Team Project
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
PR-URL: #60641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow-up of #60125.