-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
inspector: fix compressed responses #61226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
|
Tagging you @legendecas because I saw some of your work on the inspector. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #61226 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 704 704
Lines 208734 208907 +173
Branches 40271 40292 +21
==========================================
+ Hits 184823 184975 +152
- Misses 15932 15962 +30
+ Partials 7979 7970 -9
🚀 New features to boost your workflow:
|
|
I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines. Please let me know if something is missing since it's my first contribution in this repo. |
fix: #61222
Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.
This PR implements proper compression decryption if the
content-encodingheader is returned in the response headers.Repro here: https://github.com/rubnogueira/nodejs-repro-61222