Repository navigation
test_runner: fix quote escaping in JUnit - #65971
Merged
Merged
Conversation
Escape XML content before replacing double quotes and line feeds. Add a snapshot test for repeated quotes, literal quote references, and quotes mixed with ampersands, less-than signs, or a newline. Signed-off-by: hanityx <hanityx@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65971 +/- ##
==========================================
+ Coverage 90.16% 90.18% +0.02%
==========================================
Files 771 771
Lines 265445 265470 +25
Branches 50455 50459 +4
==========================================
+ Hits 239329 239421 +92
+ Misses 17056 17002 -54
+ Partials 9060 9047 -13
🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 11, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
panva
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
lpinca
approved these changes
Sep 12, 2026
panva
added
the
commit-queue
Collaborator
|
Landed in dc3b46f |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 16, 2026
Escape XML content before replacing double quotes and line feeds. Add a snapshot test for repeated quotes, literal quote references, and quotes mixed with ampersands, less-than signs, or a newline. Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: #65971 Refs: #60274 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 22, 2026
Escape XML content before replacing double quotes and line feeds. Add a snapshot test for repeated quotes, literal quote references, and quotes mixed with ampersands, less-than signs, or a newline. Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: #65971 Refs: #60274 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 25, 2026
Escape XML content before replacing double quotes and line feeds. Add a snapshot test for repeated quotes, literal quote references, and quotes mixed with ampersands, less-than signs, or a newline. Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: #65971 Refs: #60274 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
stranxik
added a commit
to stranxik/runward
that referenced
this pull request
Nov 4, 2026
…t (RWD-2026-0187, RWD-2026-0188) Node.js's junit reporter writes a `"` of a test name as `&quot;` up to 24.21.x (and in 20.x, 22.x, 25.x) and as `"` from 24.22.0 (nodejs/node#65971). Read as XML says, the old form is the literal text `"`, so `test:...::a "quoted" name` linked under one Node.js and was refused under the other (exit 1), the unreleased junit-projection-v1 seal broke on a regeneration and blamed the cases, and net-shrink counted 16 removed cases on runward's own report. A JUnit document with no `"` and at least one `&quot;` now reads `&quot;` as `"` throughout (junitWritesQuotesTwice, decodeJUnitValue); any other document is decoded once, never repeatedly. One reading for junitTestCases, junitProjection (fixed before its first release), the witness spec, the freshness recipe and, by a copy held equal by a test, net-shrink, which now says "N case(s) differ only by the reporter's escaping" and does not count them. A seal that only the other spelling of the quotes reproduces says "changed only by the reporter's quote escaping (nodejs/node#65971)", exit 1 still. The residual risk (a literal `"` in a name with no `"` anywhere) is declared, tested, and kept out of runward's own suite by a test. A quoted test name that stops at an inner `"` is refused as such, with the entity form and the unquoted form; the echo of a name carrying a `"` reads back as that name (RWD-2026-0188). Claude-Session: https://claude.ai/code/session_01WCoXsECVp3PpZLgD5NEcoU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double quotes in JUnit attribute values are escaped twice: first as
", then as&quot;. An XML reader gets the text"instead of a double quote.
Call
escapeContent()before replacing quotes and newlines.Add a snapshot test for repeated quotes, literal
", and quotesmixed with
&,<, or a newline.Refs: #60274