Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
ffi
trivikr
added
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67369 +/- ##
==========================================
- Coverage 90.73% 90.72% -0.02%
==========================================
Files 798 798
Lines 280017 280018 +1
Branches 53860 53858 -2
==========================================
- Hits 254076 254036 -40
- Misses 16235 16287 +52
+ Partials 9706 9695 -11
🚀 New features to boost your workflow:
|
new DynamicLibrary(path) read a library inside a mounted VFS before the native --allow-ffi check ran, so a missing VFS path threw ENOENT instead of ERR_ACCESS_DENIED. Check the permission first, as ffi.dlopen() does. Also correct a comment that claimed dlopen errors report the library's own path. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
ffi-dynlib-permission
branch
from
November 10, 2026 03:08
51599d6 to
3c967f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #67368
This PR calls
checkFFIPermission()in the JSDynamicLibrarywrapper before it reads from the VFS, and adds a regression assertion totest/ffi/test-ffi-permissions.js.Assisted-by: claude:opus-5.5