Skip to content

benchmark: add --expose_internals switch #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 2 commits into from
Closed

benchmark: add --expose_internals switch #8547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
167b1e6
benchmark: add --expose_internals switch
bzoz Sep 16, 2016
cbcf3ab
fixup: add comment about require in main()
bzoz Sep 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmark/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ Benchmark.prototype._run = function() {
}

const child = child_process.fork(require.main.filename, childArgs, {
env: childEnv
env: childEnv,
execArgv: ['--expose_internals'].concat(process.execArgv)
});
child.on('message', sendResult);
child.on('close', function(code) {
Expand Down
2 changes: 1 addition & 1 deletion benchmark/misc/freelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';

var common = require('../common.js');
var FreeList = require('internal/freelist').FreeList;

var bench = common.createBenchmark(main, {
n: [100000]
});

function main(conf) {
const FreeList = require('internal/freelist').FreeList;
Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this? Maybe add a comment?

Copy link
Copy Markdown
Contributor Author

@bzoz bzoz Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require was moved there, so it will work with adding -expose_internals only in common.js. It was the result of discusion here: #8547 (review)

var n = conf.n;
var poolSize = 1000;
var list = new FreeList('test', poolSize, Object);
Expand Down