Skip to content

nina 2016 code-n-learn, issue: use assert.Equal() #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianwhitedeveloper wants to merge 2 commits into from
Closed

nina 2016 code-n-learn, issue: use assert.Equal() #9977

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76f28a8
test: change `asset.equal` to `assert.strictEqual`
cdnadmin Dec 1, 2016
a66cd9a
fix code alignment
ianwhitedeveloper Dec 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/parallel/test-fs-append-file-sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ fs.appendFileSync(filename, data);

var fileData = fs.readFileSync(filename);

assert.equal(Buffer.byteLength(data), fileData.length);
assert.strictEqual(Buffer.byteLength(data), fileData.length);

// test that appends data to a non empty file
var filename2 = join(common.tmpDir, 'append-sync2.txt');
Expand All @@ -34,7 +34,7 @@ fs.appendFileSync(filename2, data);

var fileData2 = fs.readFileSync(filename2);

assert.equal(Buffer.byteLength(data) + currentFileData.length,
assert.strictEqual(Buffer.byteLength(data) + currentFileData.length,
fileData2.length);
Copy link
Contributor

@cjihrig cjihrig Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be lined up now.


// test that appendFileSync accepts buffers
Expand All @@ -46,7 +46,7 @@ fs.appendFileSync(filename3, buf);

var fileData3 = fs.readFileSync(filename3);

assert.equal(buf.length + currentFileData.length, fileData3.length);
assert.strictEqual(buf.length + currentFileData.length, fileData3.length);

// test that appendFile accepts numbers.
var filename4 = join(common.tmpDir, 'append-sync4.txt');
Expand All @@ -58,12 +58,12 @@ fs.appendFileSync(filename4, num, { mode: m });
// windows permissions aren't unix
if (!common.isWindows) {
var st = fs.statSync(filename4);
assert.equal(st.mode & 0o700, m);
assert.strictEqual(st.mode & 0o700, m);
}

var fileData4 = fs.readFileSync(filename4);

assert.equal(Buffer.byteLength('' + num) + currentFileData.length,
assert.strictEqual(Buffer.byteLength('' + num) + currentFileData.length,
fileData4.length);
Copy link
Contributor

@cjihrig cjihrig Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.


// test that appendFile accepts file descriptors
Expand All @@ -76,7 +76,7 @@ fs.closeSync(filename5fd);

var fileData5 = fs.readFileSync(filename5);

assert.equal(Buffer.byteLength(data) + currentFileData.length,
assert.strictEqual(Buffer.byteLength(data) + currentFileData.length,
fileData5.length);
Copy link
Contributor

@cjihrig cjihrig Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.


//exit logic for cleanup
Expand Down