Repository navigation
Open
Description
Current behavior
Executing node --run format, in the default branch, results in linter warnings:
Do not use item index in the array as its key @eslint-react/Desired behavior
The contributing instructions require a clean result from running linting, so this should be the case for the default branch. Executing node --run format should not produce any warnings.
Steps to reproduce
Ubuntu 26.04.1 LTS, Node.js 24.22.3
git clone https://github.com/nodejs/nodejs.org
cd nodejs.org
npm install pnpm@latest -g --allow-scripts=pnpm
pnpm install --frozen-lockfile
node --run formatLogs
$ node --run format
• turbo 2.11.10
• Packages in scope: //, @node-core/platform-cloudflare, @node-core/platform-default, @node-core/platform-vercel, @node-core/rehype-shiki, @node-core/remark-lint, @node-core/ui-components, @node-core/website, @node-core/website-i18n
• Running //#prettier:fix, prettier:fix, lint:fix in 9 packages
• Remote caching disabled
@node-core/website-i18n:lint:fix: cache bypass, force executing 09eaffde04f2f2cd
@node-core/ui-components:lint:fix: cache bypass, force executing 7d709fb4e37a0706
@node-core/website:lint:fix: cache bypass, force executing afb0048c03bf4ef5
@node-core/rehype-shiki:lint:fix: cache bypass, force executing c24568ad3f41a2e6
//:prettier:fix: cache miss, executing 8dc18b5124f2accd
@node-core/remark-lint:lint:fix: cache bypass, force executing a096df9174e4477a
@node-core/rehype-shiki:lint:fix: $ node --run lint:js:fix
@node-core/ui-components:lint:fix: $ node --run lint:js:fix && node --run lint:css:fix
@node-core/website-i18n:lint:fix: $ node --run lint:js:fix
@node-core/website:lint:fix: $ node --run lint:js:fix && node --run lint:css:fix && node --run lint:md:fix
//:prettier:fix: $ node --run prettier -- --write
@node-core/remark-lint:lint:fix: $ node --run lint:js:fix
//:prettier:fix: Checking formatting...
@node-core/ui-components:lint:fix:
@node-core/ui-components:lint:fix: /nodejs.org/packages/ui-components/src/Common/Select/StatelessSelect/index.tsx
@node-core/ui-components:lint:fix: 98:46 warning Do not use item index in the array as its key @eslint-react/no-array-index-key
@node-core/ui-components:lint:fix:
@node-core/ui-components:lint:fix: /nodejs.org/packages/ui-components/src/Common/Select/index.tsx
@node-core/ui-components:lint:fix: 87:56 warning Do not use item index in the array as its key @eslint-react/no-array-index-key
@node-core/ui-components:lint:fix:
@node-core/ui-components:lint:fix: /nodejs.org/packages/ui-components/src/Common/TableOfContents/index.tsx
@node-core/ui-components:lint:fix: 44:37 warning Do not use item index in the array as its key @eslint-react/no-array-index-key
@node-core/ui-components:lint:fix:
@node-core/ui-components:lint:fix: ✖ 3 problems (0 errors, 3 warnings)
@node-core/ui-components:lint:fix:
All matched files use Prettier code style!
Tasks: 6 successful, 6 total
Cached: 0 cached, 6 total
Time: 1m25.162sOther
Bisecting reveals that a Dependabot update "chore(deps): bump @eslint-react/eslint-plugin from 5.8.6 to 5.28.8" through #9278 triggered the warning:
$ git bisect good
9956cdb3a698bafb068fa9deaa733d8bbbcd37b1 is the first bad commit
commit 9956cdb3a698bafb068fa9deaa733d8bbbcd37b1
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Nov 1 17:47:30 2026 +0000
chore(deps): bump @eslint-react/eslint-plugin from 5.8.6 to 5.28.8 (#9278)
Bumps [@eslint-react/eslint-plugin](https://github.com/Rel1cx/eslint-react/tree/HEAD/plugins/eslint-plugin) from 5.8.6 to 5.28.8.
- [Release notes](https://github.com/Rel1cx/eslint-react/releases)
- [Changelog](https://github.com/Rel1cx/eslint-react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Rel1cx/eslint-react/commits/v5.28.8/plugins/eslint-plugin)
---
updated-dependencies:
- dependency-name: "@eslint-react/eslint-plugin"
dependency-version: 5.28.8
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
apps/site/package.json | 2 +-
packages/ui-components/package.json | 2 +-
pnpm-lock.yaml | 486 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------
3 files changed, 222 insertions(+), 268 deletions(-)Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
- StatusShow more project fields📋 Backlog
Activity