guide: add user journey memory tutorial#4728
Merged
RafaelGSS merged 3 commits intonodejs:mainfrom Jul 20, 2022
Merged
Conversation
Member
|
Hey @RafaelGSS 👋 Neat! What is the strategy here? Should we take time to review the whole content, or should we merge it quickly and then improve it incrementally? |
Member
Author
The idea is to review the whole content, so we make sure we aren't delivering an out-of-date content to end users |
Qard
reviewed
Jul 18, 2022
Member
Qard
left a comment
Qard
left a comment
There was a problem hiding this comment.
LGTM other than a few minor nits.
locale/en/docs/guides/diagnostics/memory/using-heap-snapshot.md
Outdated
Show resolved
Hide resolved
locale/en/docs/guides/diagnostics/memory/using-heap-snapshot.md
Outdated
Show resolved
Hide resolved
tony-go
reviewed
Jul 19, 2022
gireeshpunathil
approved these changes
Jul 19, 2022
tony-go
approved these changes
Jul 19, 2022
Qard
approved these changes
Jul 19, 2022
mhdawson
reviewed
Jul 19, 2022
mhdawson
reviewed
Jul 19, 2022
mhdawson
reviewed
Jul 19, 2022
locale/en/docs/guides/diagnostics/memory/using-heap-profiler.md
Outdated
Show resolved
Hide resolved
mhdawson
approved these changes
Jul 19, 2022
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM with a few small suggestions.
RafaelGSS
force-pushed
the
feat/include-memory-diagnostics
branch
3 times, most recently
from
b846b21 to
7168854
Compare
RafaelGSS
force-pushed
the
feat/include-memory-diagnostics
branch
from
7168854 to
2efaaf6
Compare
SEWeiTung
pushed a commit
that referenced
this pull request
Jul 23, 2022
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: nodejs/diagnostics#502
The Node.js Diagnostics Working Group has been creating a collection of tutorials for the past 3 years (?).
The goal is to track the user journey across various issues and provide a good reference that users can use as a baseline when diagnosing a codebase.
Those tutorials were created some time ago. We did a review, but things move fast and it might be out-of-date at some point.
cc: @nodejs/diagnostics