This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: test invalid createSocket#153
Closed
trivikr wants to merge 3 commits intonodejs:masterfrom
trivikr:test-quic-validateAddressLRU
Closed
quic: test invalid createSocket#153trivikr wants to merge 3 commits intonodejs:masterfrom trivikr:test-quic-validateAddressLRU
trivikr wants to merge 3 commits intonodejs:masterfrom
trivikr:test-quic-validateAddressLRU
Conversation
trivikr
changed the title
trivikr
changed the title
jasnell
approved these changes
Oct 6, 2019
danbev
approved these changes
Oct 7, 2019
trivikr
added a commit
that referenced
this pull request
Oct 7, 2019
PR-URL: #153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
Author
|
Landed in 746a888 |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
PR-URL: #153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
PR-URL: nodejs#153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
PR-URL: nodejs#153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were duplicate tests for
reuseAddr, they might have been added forvalidateAddressLRUwhich wasn't tested for invalid valuescommit ffd2570: added tests for invalid autoClose
Checklist