src: migrate from toucan-js to sentry sdk #833
+232
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey5
force-pushed
the
flakey5/20260127/sentry
branch
from
3dc4709 to
02dcaae
Compare
toucan-js has been deprecated in favor of the official Sentry SDK Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/20260127/sentry
branch
from
02dcaae to
0d4dc76
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
flakey5
commented
Jan 30, 2026
MattIPv4
reviewed
Jan 30, 2026
| exit 1 | ||
| fi | ||
|
|
||
| SENTRY_RELEASE=$(npx sentry-cli releases propose-version) |
Member
There was a problem hiding this comment.
Is npx sentry-cli releases propose-version guaranteed to produce the same result when run multiple times, as we've already run this in the deploy step?
Member
Author
There was a problem hiding this comment.
Afaict yes, I think it's just returning the current version plus 1. It's being ran multiple times in the official docs at least, https://docs.sentry.io/platforms/javascript/guides/cloudflare/sourcemaps/uploading/wrangler/
Member
Author
There was a problem hiding this comment.
Or, rather than incrementing some semver version looks like it's just a random id (this is just echoing out SENTRY_RELEASE w/o running any other sentry-cli things)
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a wiptoucan-js has been deprecated in favor of the official Sentry SDK re robertcepa/toucan-js#250
Also should fix #742