Skip to content

fix(fetch): do not abort fetch on redirect#2545

Merged
mcollina merged 1 commit into
nodejs:mainfrom
angelyan:main
Dec 26, 2023
Merged

fix(fetch): do not abort fetch on redirect#2545
mcollina merged 1 commit into
nodejs:mainfrom
angelyan:main

Conversation

@angelyan

Copy link
Copy Markdown
Contributor

This relates to...

#2543

Changes

Features

N/A

Bug Fixes

Fixes #2543.

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter

codecov-commenter commented Dec 26, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (5b07710) 84.64%.
Report is 174 commits behind head on main.

Files Patch % Lines
lib/fetch/index.js 67.29% 52 Missing ⚠️
lib/fetch/util.js 34.66% 49 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/compat/dispatcher-weakref.js 28.57% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 93.44% 4 Missing ⚠️
lib/core/util.js 95.55% 2 Missing ⚠️
lib/fetch/request.js 92.00% 2 Missing ⚠️
lib/core/request.js 98.21% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   85.54%   84.64%   -0.91%     
==========================================
  Files          76       80       +4     
  Lines        6858     7240     +382     
==========================================
+ Hits         5867     6128     +261     
- Misses        991     1112     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev KhafraDev requested a review from ronag December 26, 2023 16:38

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch fails with RequestContentLengthMismatchError when following redirect

4 participants