fix: count for error response and network errors #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 89 89
Lines 24171 24177 +6
=======================================
+ Hits 22597 22603 +6
Misses 1574 1574 ☔ View full report in Codecov by Sentry. |
mcollina
requested changes
Mar 15, 2024
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
Member
|
there is a conflict now, can you fix it? |
acommodari
reviewed
Mar 19, 2024
lib/handler/retry-handler.js
Outdated
| : Math.min(currentTimeout * timeoutFactor ** counter, maxTimeout) | ||
|
|
||
| state.currentTimeout = retryTimeout | ||
| : Math.min(minTimeout * timeoutFactor ** counter, maxTimeout) |
Contributor
There was a problem hiding this comment.
if counter starts at 1 should this not be (counter - 1)? This way the first retry uses the minTimeout value?
Contributor
There was a problem hiding this comment.
right now it would start at double the original minTimeout
metcoder95
force-pushed
the
fix/retry-handler
branch
from
3a9f173 to
82ad41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status