Skip to content

fix header cloning bug#3162

Merged
KhafraDev merged 4 commits into
nodejs:mainfrom
tsctx:fix/header-clone
Apr 24, 2024
Merged

fix header cloning bug#3162
KhafraDev merged 4 commits into
nodejs:mainfrom
tsctx:fix/header-clone

Conversation

@tsctx

@tsctx tsctx commented Apr 24, 2024

Copy link
Copy Markdown
Member

Refs: #3160 (comment)
Refs: #3161

@tsctx tsctx requested a review from KhafraDev April 24, 2024 21:41

@KhafraDev KhafraDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci, this is what I was thinking

Comment thread lib/web/fetch/headers.js Outdated
Comment thread lib/web/fetch/headers.js Outdated
@codecov-commenter

codecov-commenter commented Apr 24, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (034e3f0) to head (9493e11).
⚠️ Report is 970 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3162       +/-   ##
=========================================
+ Coverage      0   94.13%   +94.13%     
=========================================
  Files         0       90       +90     
  Lines         0    24334    +24334     
=========================================
+ Hits          0    22908    +22908     
- Misses        0     1426     +1426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/web/fetch/headers.js Outdated
Comment thread lib/web/fetch/headers.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants