build: parametrize the location of wasm-opt#3454
Merged
Uzlopak merged 1 commit intonodejs:mainfrom Aug 14, 2024
Merged
Conversation
The wasm-opt binary may be available in different place than the local directory (`./wasm-opt`) – for example, in /usr/bin/wasm-opt. Similarly to the other parametrized WASM build options, use WASM_OPT environment variable to identify the wanted binary, with fallback to the previous value. Even with the environment variable available, the `hasOptimizer` is kept to make the optimization optional. Signed-off-by: Jan Staněk <jstanek@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (hasOptimizer) { | ||
| execSync(`./wasm-opt ${WASM_OPT_FLAGS} -o ${join(WASM_OUT, 'llhttp.wasm')} ${join(WASM_OUT, 'llhttp.wasm')}`, { stdio: 'inherit' }) | ||
| execSync(`${WASM_OPT} ${WASM_OPT_FLAGS} -o ${join(WASM_OUT, 'llhttp.wasm')} ${join(WASM_OUT, 'llhttp.wasm')}`, { stdio: 'inherit' }) |
Check warning
Code scanning / CodeQL
Shell command built from environment values
|
|
||
| if (hasOptimizer) { | ||
| execSync(`./wasm-opt ${WASM_OPT_FLAGS} --enable-simd -o ${join(WASM_OUT, 'llhttp_simd.wasm')} ${join(WASM_OUT, 'llhttp_simd.wasm')}`, { stdio: 'inherit' }) | ||
| execSync(`${WASM_OPT} ${WASM_OPT_FLAGS} --enable-simd -o ${join(WASM_OUT, 'llhttp_simd.wasm')} ${join(WASM_OUT, 'llhttp_simd.wasm')}`, { stdio: 'inherit' }) |
Check warning
Code scanning / CodeQL
Shell command built from environment values
metcoder95
approved these changes
Aug 13, 2024
mcollina
pushed a commit
that referenced
this pull request
Aug 17, 2024
The wasm-opt binary may be available in different place than the local directory (`./wasm-opt`) – for example, in /usr/bin/wasm-opt. Similarly to the other parametrized WASM build options, use WASM_OPT environment variable to identify the wanted binary, with fallback to the previous value. Even with the environment variable available, the `hasOptimizer` is kept to make the optimization optional. Signed-off-by: Jan Staněk <jstanek@redhat.com>
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Enhances: #3421
Rationale
The wasm-opt binary may be available in different place than the local directory (
./wasm-opt) – for example, in/usr/bin/wasm-opt.Changes
Similarly to the other parametrized WASM build options, use WASM_OPT environment variable to identify the wanted binary, with fallback to the previous value (
./wasm-opt).Even with the new environment variable, the
hasOptimizercheck is kept for the cases where no optimizer is available anywhere.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status