fix: restructure determineRequestsReferrer to match better spec#3699
Merged
fix: restructure determineRequestsReferrer to match better spec#3699
Conversation
KhafraDev
approved these changes
Oct 8, 2024
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
Is it obvious that I didn't originally implement this? 😜
Contributor
Author
|
Well atleast I get once i a while an approval for a fetch PR 😜 |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I investigated if there were significant changes in esbuild, I found the following change:
So the comments were added because they were of
/** */notation and not of//notation. While I fixed, I saw that the implementation is not matching 1:1 the spec text, like the order of the cases. So I adapted it accordingly.