Merged
Conversation
KhafraDev
reviewed
Oct 22, 2024
Member
|
I think this is a bit too light on tests, and I'm not sure if this implementation is correct. Can you add some tests where the response is a 304 thanks to if-none-match? |
Contributor
Also, we could test how undici responds to different server implementations. I myself have run into situations when locally stored strong ETag matches the server-sent one yet the server is returning the same ETag with 200 instead of 304. |
flakey5
force-pushed
the
flakey5/3718
branch
2 times, most recently
from
d914909 to
9eeff6c
Compare
ronag
approved these changes
Nov 18, 2024
metcoder95
approved these changes
Nov 18, 2024
Member
|
@flakey5 this now conflicts |
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
flakey5
force-pushed
the
flakey5/3718
branch
from
9eeff6c to
7ed13ec
Compare
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re http caching, adds support for etags for when we need to revalidate a cached response.
No breaking changes to the public api. the
etagproperty is nullable so a cache store could just not implement it and it will be fine. However, I did add it to the tests as if it was required just so we can ensure the builtin cache stores fully support the behavior.This only checks if the etag exists in the response's headers and ignores it if it's in the trailers for simplicity sakes (as allowed by the spec in 8.8.3)
Closes #3718