Merged
Conversation
Member
Author
ronag
force-pushed
the
cache-fixes-4
branch
7 times, most recently
from
0af8339 to
72f8f7e
Compare
ronag
force-pushed
the
cache-fixes-4
branch
2 times, most recently
from
a6e60f1 to
2840fe7
Compare
Uzlopak
reviewed
Nov 13, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
I love the direction this PR takes
flakey5
suggested changes
Nov 13, 2024
| response: CachedResponse | ||
| body?: Readable | ||
| } | ||
| type GetResult = CachedResponse & { body: null | Readable | Iterable<Buffer> | Buffer | Iterable<string> | string } |
Member
There was a problem hiding this comment.
Could you add some more testing in the interceptor test file for each of the body types?
flakey5
pushed a commit
to flakey5/undici
that referenced
this pull request
Nov 14, 2024
Merged
1 task
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status