Merged
Conversation
mcollina
requested changes
Apr 5, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
this is not enough to close that, as one header is missing. A test should also be added for that specific case.
metcoder95
changed the title
Merged
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #4086
Rationale
Do we see a potential harm of this? I know the original idea was to tell the queue not to re-use the socket so it can be used by the caller instead.
From tests, everything seems normal, but wondering if there's something possibly that I'm not seeing to not do it.
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status