Closed
Conversation
This reverts commit 9f7fafe.
metcoder95
approved these changes
Sep 8, 2025
Member
|
Can you please add a regression test? |
Contributor
Author
|
I am not sure regarding regressions. I wanted to put this up for discussion. I was partially hoping that it maybe fixes the macos ci issues. Anyhow. My plan would be actually to create a PR against nodejs with the contents of this PR, and see if nodejs is still broken on those other architectures. |
Member
|
Try getting the test working, I would prefer to not land this unless we have a regression - and if we do have a regression test, we can get @ShogunPanda fix it in llhttp and avoid reverting it completely. |
Contributor
Author
|
THe problem is, that I dont have a computer with AIX or ppc64. |
Member
|
Wait, is the problem only on AIX or PPC? |
Contributor
Author
|
That what I am seeing. |
Contributor
Author
|
Assuming that this is basically obsolete due to #4530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4431