Merged
Conversation
Git was taking the -S keyid as filepaths and failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully resolve #63
For anyone watching at home, npm broke their package-json-flattening-as-env behavior. So
npm_package_actionswas no longer a valid env var. And instead of failing on the reference, it just quietly replaced with empty string. So npm breaks a long-standing feature. And their shell setup still doesn't use-uto help guard unset env vars.So with the
preparescript no longer actually, ya know, PREPARING ANYTHING, thenpm cistep was now essentially a noop. Which meant the build.yml workflow was quietly broken as well.thanks npm.