Addressing issue of wrongly freeing un- or StatefulSet managed Pod IPs#5
Merged
Addressing issue of wrongly freeing un- or StatefulSet managed Pod IPs#5
Conversation
Levovar
changed the title
This is needed to be able to definitively decide if a DanmEp's Pod exists, or not. Also added a delay, and a re-check before we free an IP to avod accidentally racing with an ongoing CNI operation. Lastly, to be inline with recent upstream DANM change DanmEp is not cleared when an IP could not be freed for some reason. It iwll result ins a retrial during the next periodic tick.
Levovar
force-pushed
the
cluster_restart
branch
from
d3a46db to
9ec63db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supposed to fix #4
Changing Pod name check to also compare Pod UID when deciding if a Pod belongs to a DanmEp, or not.
This is needed to be able to definitively decide if a DanmEp's Pod exists, or not.
Also added a delay, and a re-check before we free an IP to avod accidentally racing with an ongoing CNI operation.
Lastly, to be inline with recent upstream DANM change DanmEp is not cleared anymore when an IP could not be freed for some reason.
This will result in a retrial during the next periodic tick.