fix: Add contract version to plugin sign request and plugin verify request#390
Merged
priteshbandi merged 2 commits intonotaryproject:mainfrom Mar 21, 2024
Merged
fix: Add contract version to plugin sign request and plugin verify request#390priteshbandi merged 2 commits intonotaryproject:mainfrom
priteshbandi merged 2 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
priteshbandi
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
rgnote,
shizhMSFT and
toddysm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 73.43% 75.38% +1.94%
==========================================
Files 24 24
Lines 2507 2023 -484
==========================================
- Hits 1841 1525 -316
+ Misses 526 353 -173
- Partials 140 145 +5 ☔ View full report in Codecov by Sentry. |
priteshbandi
added a commit
to priteshbandi/notation-go
that referenced
this pull request
Apr 2, 2024
…quest (notaryproject#390) Add contract version to plugin sign request and plugin verify request. As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field. Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
priteshbandi
added a commit
to priteshbandi/notation-go
that referenced
this pull request
Apr 2, 2024
…quest (notaryproject#390) Add contract version to plugin sign request and plugin verify request. As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field. Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
JeyJeyGao
pushed a commit
that referenced
this pull request
May 29, 2024
…quest (#390) Add contract version to plugin sign request and plugin verify request. As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field. Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add contract version to plugin sign request and plugin verify request.
As per specification
contractVersionis a mandatory field.