Skip to content

chore: fix logs#417

Merged
5 commits merged intomainfrom
unknown repository
Jul 17, 2024
Merged

chore: fix logs#417
5 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 26, 2024

A chore PR to fix a few log formats.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost linked an issue Jun 26, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (b525831) to head (b55116f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files          33       33           
  Lines        2449     2449           
=======================================
  Hits         1978     1978           
  Misses        331      331           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost closed this Jul 17, 2024
Patrick Zheng added 2 commits July 17, 2024 11:10
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Jul 17, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 8ada12a into notaryproject:main Jul 17, 2024
@ghost ghost deleted the fix branch July 17, 2024 04:44
@ghost ghost mentioned this pull request Jul 23, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading and inconsistent logs

2 participants