Skip to content

refactor!: remove blob sign/verify related code#437

Merged
12 commits merged intorelease-1.2from
unknown repository
Aug 16, 2024
Merged

refactor!: remove blob sign/verify related code#437
12 commits merged intorelease-1.2from
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 14, 2024

As discussed, this PR removes the blob sign/verify related code for v1.2.0 release.

This PR targets on branch release-1.2 ONLY.

Patrick Zheng added 4 commits August 9, 2024 09:38
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (3c5a659) to head (d5e876a).
Report is 1 commits behind head on release-1.2.

Files Patch % Lines
verifier/verifier.go 82.35% 2 Missing and 1 partial ⚠️
verifier/trustpolicy/oci.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2     #437      +/-   ##
===============================================
+ Coverage        80.86%   81.21%   +0.34%     
===============================================
  Files               33       32       -1     
  Lines             2483     2279     -204     
===============================================
- Hits              2008     1851     -157     
+ Misses             332      299      -33     
+ Partials           143      129      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Patrick Zheng added 2 commits August 14, 2024 10:42
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from JeyJeyGao August 14, 2024 05:53
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from JeyJeyGao August 14, 2024 07:27
JeyJeyGao
JeyJeyGao previously approved these changes Aug 14, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title refactor!: removed blob sign/verify related code for v1.2.0 release refactor!: remove blob sign/verify related code Aug 14, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested review from JeyJeyGao and shizhMSFT August 15, 2024 01:25
JeyJeyGao
JeyJeyGao previously approved these changes Aug 15, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 15, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost dismissed stale reviews from shizhMSFT and JeyJeyGao via 1b66429 August 15, 2024 03:10
@ghost ghost requested review from JeyJeyGao and shizhMSFT August 15, 2024 03:19
JeyJeyGao
JeyJeyGao previously approved these changes Aug 15, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Aug 15, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit a83c5be into notaryproject:release-1.2 Aug 16, 2024
@ghost ghost deleted the release branch August 16, 2024 02:13
@ghost ghost mentioned this pull request Aug 16, 2024
6 tasks
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the changes it is LGTM

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants