fix: cherry pick fix of plugin output size (#484) to release-1.3 branch#494
Merged
1 commit merged intorelease-1.3from Dec 13, 2024
unknown repository
Merged
fix: cherry pick fix of plugin output size (#484) to release-1.3 branch#4941 commit merged intorelease-1.3from unknown repository
1 commit merged intorelease-1.3from
unknown repository
Conversation
Fix: - set the plugin output limit for STDOUT and STDERR to be 10MiB Test: - when the plugin output size exceeds 64MiB, the output pipe breaks, and the plugin process outputs an error to STDERR Spec changes: notaryproject/specifications#320 Resolves #187 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #494 +/- ##
===============================================
+ Coverage 80.88% 80.97% +0.08%
===============================================
Files 33 34 +1
Lines 3066 3080 +14
===============================================
+ Hits 2480 2494 +14
Misses 455 455
Partials 131 131 ☔ View full report in Codecov by Sentry. |
shizhMSFT
approved these changes
Dec 13, 2024
Contributor
shizhMSFT
left a comment
shizhMSFT
left a comment
There was a problem hiding this comment.
LGTM. Note that this PR should be merged by creating a merge commit without squashing.
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for
release-1.3branch.