fix: remove signing time check during authenticTimestamp#514
Merged
1 commit merged intorelease-1.3from Feb 20, 2025
unknown repository
Merged
fix: remove signing time check during authenticTimestamp#5141 commit merged intorelease-1.3from unknown repository
1 commit merged intorelease-1.3from
unknown repository
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #514 +/- ##
===============================================
- Coverage 80.97% 80.95% -0.02%
===============================================
Files 34 34
Lines 3080 3077 -3
===============================================
- Hits 2494 2491 -3
Misses 455 455
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Contributor
|
This PR reverts #478 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the signing time check against timestamp during authentic timestamp verification. The possibility of time skew requires further discussion on the check.
Resolves: #513