Skip to content

fix: update error message for signing key config#527

Merged
4 commits merged intomainfrom
unknown repository
Mar 24, 2025
Merged

fix: update error message for signing key config#527
4 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 24, 2025

This PR contains some error message enhancements found while using the library.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (fdcf9cc) to head (7157785).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   80.87%   80.92%   +0.04%     
==========================================
  Files          35       36       +1     
  Lines        3352     3355       +3     
==========================================
+ Hits         2711     2715       +4     
+ Misses        494      493       -1     
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Patrick Zheng added 2 commits March 24, 2025 13:21
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT March 24, 2025 05:42
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit fcc1ce3 into notaryproject:main Mar 24, 2025
9 checks passed
@ghost ghost deleted the fix branch March 24, 2025 06:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants