Draft
Conversation
- Use deep merge in getControlsDefaultValues to preserve nested defaults like redirect.target when controlValues has a partial redirect object - Change EditStepTemplateV2Page to use defaultValues (which includes deep-merged server values + UI schema defaults) as the values prop to prevent React Hook Form resets from losing nested field values - Add useEffect fallback in URLInput to restore target to first option when value becomes undefined, and use fallback in Select value prop - Fix sanitizeRedirect to default target based on URL type (relative paths get _self, absolute URLs get _blank) when target is missing Fixes NV-7104 Co-authored-by: Dima Grossman <dima@grossman.io>
Contributor
|
Cursor Agent can help with this pull request. Just |
✅ Deploy preview added
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted. Your PR title is: Requirements:
Expected format: Details: PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This PR resolves NV-7104, where the in-app step redirect URL target would reset and show persistent validation errors.
The issue stemmed from a combination of factors:
redirect.targetto be lost if the incomingcontrolValueshad a partialredirectobject.valuesprop not being initialized with fully merged default values, leading to resets losing nested fields.sanitizeRedirectfunction not consistently providing a defaulttargetwhen a redirect URL was present.To address this, the following changes were made:
deepMergeDefaultsutility to correctly merge nested default values.EditStepTemplateV2Pageto use the deeply mergeddefaultValuesfor React Hook Form'svaluesprop.useEffecttoURLInputto ensure thetargetalways defaults to_selfif undefined.sanitizeRedirectto explicitly settargetto_selffor relative URLs and_blankfor absolute URLs if it's missing.Screenshots
Linear Issue: NV-7104