You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I actually liked it better before you added the explicit RequireAuthMode.All, because we share PGREQUIREAUTH with libpq and before adding it we were 100% syntax compatible whereas now we have the All mode in addition.
It's not a big deal because our default for the unset option is the same as libpq's (All) but if users explicitly set PGREQIREAUTH to All because they think that it's a good idea or required, they break libpq connections.
I actually liked it better before you added the explicit RequireAuthMode.All, because we share PGREQUIREAUTH with libpq and before adding it we were 100% syntax compatible whereas now we have the All mode in addition.
It's not a big deal because our default for the unset option is the same as libpq's (All) but if users explicitly set PGREQIREAUTH to All because they think that it's a good idea or required, they break libpq connections.
I think we can just disallow parsing ALL, it's an internal enum after all, so as long as we do not document it publicly...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6035