Closed
Conversation
Contributor
|
replacing Travis is a massive change that both should happen in its own commit, and its own pr |
Contributor
Author
|
@ljharb Yes, and it is separated in the dependency's repository. Did you mean it should be major update in terms of semver? I can bump major version in that case. |
Contributor
|
@watilde sorry, what i meant is, updating "how CI works" in this repo is something that deserves its own PR. Updating |
Contributor
Author
|
@ljharb Got it! Thank you for your clear explanation and review<3 |
ruyadorno
approved these changes
Aug 14, 2020
ruyadorno
added a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #1544 Credit: @watilde Close: #1544 Reviewed-by: @ruyadorno
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the version of meant
Updates:
Refs: https://github.com/watilde/meant/blob/master/CHANGELOG.md#102-2020-07-19