fix: encode url before opening#3804
Merged
wraithgar merged 1 commit intorelease-nextfrom Sep 27, 2021
Merged
Conversation
isaacs
approved these changes
Sep 27, 2021
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
looks good to me! (unsurprisingly, perhaps)
will filter out a small subset of non-URL-safe characters that still parse properly with `new URL` PR-URL: #3804 Credit: @isaacs Close: #3804 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
gar/windows-open-url
branch
from
0541bef to
56d6cfd
Compare
|
It seems this change has broken "npm help whatever" functionality, as the encoded URI doesn't pass check in line 28: If the new line 7 which encodes URI commented, npm help commands work fine again. |
Member
Author
|
2 years have passed and this is still unfixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will filter out a small subset of non-URL-safe characters that still
parse properly with
new URLCredit: @isaacs