chore: backport benchmark, node PR, and smoke tests chores#6877
Merged
lukekarrys merged 6 commits intorelease/v9from Oct 6, 2023
Merged
chore: backport benchmark, node PR, and smoke tests chores#6877lukekarrys merged 6 commits intorelease/v9from
lukekarrys merged 6 commits intorelease/v9from
Conversation
Contributor
lukekarrys
commented
Oct 6, 2023
lukekarrys
commented
- chore: filter node prs by base branch
- chore: fix variable name in benchmark trigger
- chore: send benchmark dispatch to correct repo
- chore: benchmark script fixes (chore: benchmark script fixes #6824)
- chore: append target branch to branch name when creating Node PR
- chore: use proxy instead of http-proxy (chore: use proxy instead of http-proxy #6814)
This is a fix to allow multiple Node PRs to be open. Previously the script would attempt to edit an existing PR but PRs to different branches were getting incorrectly edited.
This passes the token to the github-script action and now skips the PR workflow for forks in the if statement instead of while running the script
The proxy package is more spec compliant and works out-of-the-box so we no longer have to pass --registry=PROXY to the tests. The goal here is to make it simpler to help debug #6793.
lukekarrys
changed the title
Merged
Member
|
The dependency #6814 landed in |
wraithgar
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.