This repository was archived by the owner on May 4, 2024. It is now read-only.
20% npm install speedup: cache extras by package.json string#70
Closed
mikesherov wants to merge 1 commit into
Closed
20% npm install speedup: cache extras by package.json string#70mikesherov wants to merge 1 commit into
mikesherov wants to merge 1 commit into
Conversation
Contributor
|
This was merged into v2.0.7 as 839b56e. Thank you so much! =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL:DR
~20% speed up in the average npm install run when combined with npm/hosted-git-info#24
Details
This package used to actually cache package.json lookups, until b746f65 which was an attempt to fix npm/npm#7074 Deleting the caching mechanism definitely helped fix a correctness issue, but threw the baby out with the bath water. This PR introduces a less aggressive cache by caching by the true cache key, which is the string contents of a package.json file. Should be 100% safe to cache results based on this... I believe.
This lets us speed up builds quite a bit!
Before:
After
Let me know if you have any questions