Problems pushing content to the API

[benlk]

Reported by @eteare:

I have been struggling to publish to the Story API from the plugin. I can get stories from the Story API no prob (one story, or an auto publish of a collection), but no PUT or POST from the site I am testing on. We are looking at Kibana to find these requests.

I’ve gone round a few times, checking all the configs and Ben, can you double check one thing for us? Can you check that for POST and PUT requests that the URL is /story and not /query? That’s the one guess we have right now on why, perhaps, no stories are getting to the API.

[benlk]

When pushing content to the API, the URL is /story and it is making a POST request:

nprapi-wordpress/classes/NPRAPIWordpress.php

Lines 547 to 554 in 26a44bf

	$url = add_query_arg( array(
	'orgId' => $org_id,
	'apiKey' => get_option( 'ds_npr_api_key' )
	), get_option( 'ds_npr_api_push_url' ) . '/story' );
	nprstory_error_log( 'Sending nprml = ' . $nprml );
	$result = wp_remote_post( $url, array( 'body' => $nprml ) );

Erin says that NPR is taking another look to see if they can determine what the problem is.

[benlk]

I'm not even seeing the "org ID not set" error that should be showing in my server log, because I'm attempting to push to the sandbox without an Org ID.

nprapi-wordpress/classes/NPRAPIWordpress.php

Lines 582 to 585 in 26a44bf

	} else {
	$error_text = 'OrgID was not set when tried to push post_ID ' . $post_ID . ' to the NPR Story API.';
	error_log ( $error_text ); // debug use
	}

[benlk]

It's because this URL parameter is no longer set:

nprapi-wordpress/push_story.php

Lines 124 to 128 in a58353b

	if ( isset( $_POST['ds_npr_update_push'] ) ) {
	// No need to validate the ds_npr_update_push contents; we're checking only for its existence
	// permissions check is handled by nprstory_api_push
	add_action( 'save_post', 'nprstory_api_push', 10, 2 );
	}

That URL parameter was set before #47, and is not set afterwards. The pull request removed the submit_button( 'Push to NPR', 'large', 'ds_npr_update_push', false, $attrs ); button, which set that URL parameter, and replaced it with a checkbox that added a different parameter to the URL.

[benlk]

With an org ID set:

Fatal error: Uncaught Error: Cannot use string offset as an array in /Users/blk/sites/nprapi/wp-content/plugins/nprapi-wordpress/push_story.php:463
Stack trace:
0 /Users/blk/sites/nprapi/wp-content/plugins/nprapi-wordpress/settings.php(238): nprstory_get_permission_groups()
1 /Users/blk/sites/nprapi/wp-admin/includes/template.php(1388): nprstory_push_story_permissions_callback(Array)
2 /Users/blk/sites/nprapi/wp-admin/includes/template.php(1347): do_settings_fields('ds_npr_api', 'ds_npr_api_sett...')
3 /Users/blk/sites/nprapi/wp-content/plugins/nprapi-wordpress/settings_ui.php(14): do_settings_sections('ds_npr_api')
4 /Users/blk/sites/nprapi/wp-includes/class-wp-hook.php(286): nprstory_api_options_page('')
5 /Users/blk/sites/nprapi/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters('', Array)
6 /Users/blk/sites/nprapi/wp-includes/plugin.php(453): WP_Hook->do_action(Array)
7 /Users/blk/sites/nprapi/wp-admin/admin.php(224): do_action('settings_page_d...')
8 /Users/blk/sites/nprapi/wp-admin/options-general.php(10): require_once('/Users/blk/site...')
9 /Users/blk/.composer/vendor/laravel/valet/server.php(147): require('/Users/blk/site...')
10 {main}

thrown in /Users/blk/sites/nprapi/wp-content/plugins/nprapi-wordpress/push_story.php on line 463

[benlk]

That's fixed by 63c25f0

[eteare]

Ben, I pulled a repo with this branch and successfully posted to the API. Success!

[benlk]

👍

[benlk]

#60 has merged, so moving this to the "Done" category.