fix(js): add {projectRoot} prefix to d.ts fileset in typescript plugin#35037
Merged
FrozenPandaz merged 3 commits intomasterfrom Mar 27, 2026
Merged
fix(js): add {projectRoot} prefix to d.ts fileset in typescript plugin#35037FrozenPandaz merged 3 commits intomasterfrom
FrozenPandaz merged 3 commits intomasterfrom
Conversation
The typescript plugin was emitting a bare `**/*.d.ts` fileset input
without the required `{projectRoot}/` prefix, causing the Nx hasher
to warn: "**/*.d.ts does not start with {workspaceRoot}/"
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 47ba086
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Mar 27, 2026
The typescript plugin was emitting a bare `**/*.d.ts` fileset input
without the required `{projectRoot}/` prefix, causing the Nx hasher
to warn: "**/*.d.ts does not start with {workspaceRoot}/" [Self-Healing CI Rerun]
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The typescript plugin was emitting a bare `**/*.d.ts` fileset input
without the required `{projectRoot}/` prefix, causing the Nx hasher
to warn: "**/*.d.ts does not start with {workspaceRoot}/" [Self-Healing CI Rerun]
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
FrozenPandaz
added a commit
that referenced
this pull request
Mar 27, 2026
#35037) ## Current Behavior The TypeScript plugin emits a bare `**/*.d.ts` fileset input (without a `{projectRoot}/` prefix) for dependency file tracking. The Nx hasher expects all filesets to start with either `{projectRoot}/` or `{workspaceRoot}/`, so it logs a warning for every project: ``` NX **/*.d.ts does not start with {workspaceRoot}/. This will throw an error in Nx 20. ``` ## Expected Behavior No warning is emitted. The fileset correctly uses `{projectRoot}/**/*.d.ts` so the hasher knows it's scoped to the dependency project's root. ## Related Issue(s) N/A — discovered while debugging e2e test failures. (cherry picked from commit 6c92d92)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The TypeScript plugin emits a bare
**/*.d.tsfileset input (without a{projectRoot}/prefix) for dependency file tracking. This was introduced in #34968. The Nx hasher expects all filesets to start with either{projectRoot}/or{workspaceRoot}/, so it logs a warning for every project:Expected Behavior
No warning is emitted. The fileset correctly uses
{projectRoot}/**/*.d.tsso the hasher knows it's scoped to the dependency project's root.Related Issue(s)
Fixes regression from #34968.