Use ThreadingHTTPServer to fix deadlock on concurrent requests#179
Open
domdomegg wants to merge 1 commit intonschloe:mainfrom
Open
Use ThreadingHTTPServer to fix deadlock on concurrent requests#179domdomegg wants to merge 1 commit intonschloe:mainfrom
domdomegg wants to merge 1 commit intonschloe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tuna's server mode uses
HTTPServer(single-threaded) with HTTP/1.1. When a browser loads a page it sends concurrent requests (HTML + CSS + JS + favicon), and the single-threaded server deadlocks on HTTP keep-alive connections — it blocks reading for a follow-up request on one connection instead of accepting the next queued connection.This switches to
ThreadingHTTPServer(whichpython -m http.serveralso uses) so each connection is handled in its own thread.Fixes #178