adding tls certificate match to proto.txt#3099
Open
kalindafab wants to merge 3 commits intontop:devfrom
Open
Conversation
Collaborator
|
@kalindafab, could you add a simple example rule in |
|
Contributor
Author
|
I added unit test but the parsing issue is so complex :) |
|
Member
|
We need to match the certificate hash, not the .pem certificate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:#3021
Describe changes:
Adds support for dynamic TLS certificate–based subprotocol detection using a new @tls_cert: rule syntax. Rules are parsed at runtime, stored in the detection module, and matched against TLS certificate Subject/Issuer fields during inspection.
The implementation follows existing dynamic rule patterns as @ja4:, @ndpifp:), includes proper initialization/cleanup.
Request for Review:
@lucaderi Hi! I'm working on implementing this feature but running into a protocol name parsing issue. The error messages suggest the protocol name is being extracted from the certificate pattern rather than from before the
@tls_cert:part.Could you point me to how protocol names are supposed to be extracted for new attribute types? Looking at the existing
@ja4:and@ndpifp:handlers, I tried to follow the same pattern, but something isn't working correctly.Any guidance would be appreciated! Happy to make any changes needed.