feat: harden flow architecture — review-gate consolidation, planning simplification, flow hardening#147
Merged
Conversation
…hitecture - Collapse review-gate-flow (3-state subflow) into single review-gate state with 3-tier fail-fast skill (design -> structure -> conventions) - Add committed==verified condition gate on review-gate.pass -> done - Remove 4 orphaned review skills (architecture, design, structure, conventions) - Simplify planning flow (6->5 states): remove definition-of-done and ready states, consolidate conditions into single evidence atoms - Add spec-review state (R) between feature-examples and create-py-stubs - Detach post-mortem as independent flow (manual trigger) - Remove wasteful backward arrows: needs-planning, needs-respecification - Make rejected an exit from feature-development-flow (not auto-replan) - Rename structure-project -> structure-feature (scope corrected) - Split stub-design.md -> source-stubs.md + test-stubs.md - Add Behavioral Distinctness, Behavior Pre-Mortem, Invariant Property Tests concepts across gherkin.md, pre-mortem.md, test-design.md - Eliminate Status field from feature specs (content-based evidence instead) - Fix stale flow-version references across all flows - Update mermaid extension .mermaid -> .yaml.mermaid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapses the 3-state review-gate subflow into a single state with a 3-tier fail-fast skill. Hardens the feature-development-flow by eliminating wasteful backward arrows and making rejected an exit. Simplifies planning flow by removing thin verification states.
Changes
Review Consolidation
review-gate-flow.yaml(3-state subflow)review-architecture,review-design,review-structure,review-conventions)review-gateskill — 3-tier fail-fast (design → structure → conventions)review-specskill for spec-review state in planning flowcommitted==verifiedcondition gate onreview-gate.pass → doneFlow Architecture Hardening
needs-planningback-edge from development-flow (specs are baselined, issues are flagged not looped)rejectedan exit from feature-development-flow (stakeholder decides: post-mortem, cancel, or replan)rejectedto main-flow exitspost-mortemstate from feature-development-flow (now standalone manual trigger)Planning Flow Simplification
definition-of-doneandreadystates (thin verification, content-based evidence instead)invest-passed==verified, 9 example atoms → singleexamples-complete==verifiedspec-reviewstate (R) betweenfeature-examplesandcreate-py-stubsneeds-respecificationloops (skills enforce quality as hard blockers)Cleanup
structure-project→structure-feature(scope corrected)stub-design.md→source-stubs.md+test-stubs.mdconfirm-baseline,define-done,model-domain)File Count