feat: remove Questions table from feature files, consolidate Q&A to interview notes#148
Merged
Merged
Conversation
…hitecture - Collapse review-gate-flow (3-state subflow) into single review-gate state with 3-tier fail-fast skill (design -> structure -> conventions) - Add committed==verified condition gate on review-gate.pass -> done - Remove 4 orphaned review skills (architecture, design, structure, conventions) - Simplify planning flow (6->5 states): remove definition-of-done and ready states, consolidate conditions into single evidence atoms - Add spec-review state (R) between feature-examples and create-py-stubs - Detach post-mortem as independent flow (manual trigger) - Remove wasteful backward arrows: needs-planning, needs-respecification - Make rejected an exit from feature-development-flow (not auto-replan) - Rename structure-project -> structure-feature (scope corrected) - Split stub-design.md -> source-stubs.md + test-stubs.md - Add Behavioral Distinctness, Behavior Pre-Mortem, Invariant Property Tests concepts across gherkin.md, pre-mortem.md, test-design.md - Eliminate Status field from feature specs (content-based evidence instead) - Fix stale flow-version references across all flows - Update mermaid extension .mermaid -> .yaml.mermaid
…nterview notes The Questions table in feature files was a downstream working scratchpad that duplicated the interview notes' role as the source of Q&A. Feature files now contain only the finished product (description, rules, constraints, examples). Changes: - Remove ## Questions section and Q-IDs column from feature template - Redirect gap flagging, clarification capture, and pre-mortem findings from feature Questions table to interview notes across all skills and knowledge files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.featurefiles — Q&A for specification lives in interview notes, not duplicated in feature filesOnce rules and examples are written, the raw Q&A used to produce them belongs in interview notes. Feature files are the finished product.