Skip to content

Fix deprecated get -i flag; Fix unreliable test #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubouch merged 3 commits into from
Aug 15, 2025
Merged

Fix deprecated get -i flag; Fix unreliable test #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2a57b6
Fix deprecated get -i
kubouch Aug 15, 2025
65e7140
Fix env test
kubouch Aug 15, 2025
7447f43
Update Nushell version
kubouch Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- uses: hustcer/setup-nu@v3.10
with:
version: "0.105.1"
version: "0.106.1"

- name: Show Nushell Version
run: version
Expand Down
2 changes: 1 addition & 1 deletion nupm/publish.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def guess-revision []: nothing -> string {

def get-registry-path []: string -> path {
let registry = $in
$env.NUPM_REGISTRIES | get -i $registry | default ($registry | path expand)
$env.NUPM_REGISTRIES | get -o $registry | default ($registry | path expand)
}

def open-registry-file []: path -> table<name: string, path: string, url: string> {
Expand Down
2 changes: 1 addition & 1 deletion nupm/utils/package.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export def open-package-file [dir: path] {
log debug "checking package file for missing required keys"
let required_keys = [$. $.name $.version $.type]
let missing_keys = $required_keys
| where {|key| ($package | get -i $key) == null}
| where {|key| ($package | get -o $key) == null}
if not ($missing_keys | is-empty) {
throw-error "invalid_package_file" (
$"($package_file) is missing the following required keys:"
Expand Down
4 changes: 3 additions & 1 deletion tests/mod.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ export def env-vars-are-set [] {
assert equal $env.NUPM_HOME $dirs.DEFAULT_NUPM_HOME
assert equal $env.NUPM_TEMP $dirs.DEFAULT_NUPM_TEMP
assert equal $env.NUPM_CACHE $dirs.DEFAULT_NUPM_CACHE
assert equal $env.NUPM_REGISTRIES $dirs.DEFAULT_NUPM_REGISTRIES
(assert equal
$env.NUPM_REGISTRIES
($env.NUPM_REGISTRIES | merge $dirs.DEFAULT_NUPM_REGISTRIES))
}

export def generate-local-registry [] {
Expand Down
Loading