feat: collection hashing for multi instance support#3276
Open
GerryWilko wants to merge 5 commits intonuxt:mainfrom
Open
feat: collection hashing for multi instance support#3276GerryWilko wants to merge 5 commits intonuxt:mainfrom
GerryWilko wants to merge 5 commits intonuxt:mainfrom
Conversation
commit: |
Member
|
Thanks @GerryWilko for the issue and PR, Instead of adding hash suffix, we can add support for a custom table prefix. This way in tests each instance can define its own prefix. Also this would be useful in production, you can share sam database between two or more applications. |
Contributor
|
@GerryWilko curious if you have any further thoughts on this? (per the comment above) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fixes #3273
❓ Type of change
📚 Description
This PR aims to address issues related to multiple running instances of Nuxt connecting to the same collection database by optimizing the module initialization and removing the need to drop all content tables and recreate each time.
I have proposed moving the collection
hashinto theresolveCollectionfunction and using the first four safe characters as part of the table name. This allows collections that have not been altered to be left untouched during initialization allowing for multiple connecting Nuxt instances to run the module without interfering with each other.Do let me know if there is anything you would like me to change here.
📝 Checklist