[akj]

Link to issue number:

Fixes #18905

Summary of the issue:

The NVDA installer (launcher) uses the installed copy's configuration.
If that configuration was saved by a newer version of NVDA, an earlier installer may not be able to load it.
The installer then treats the file as corrupted: it renames nvda.ini to nvda.ini.corrupted.bak and continues with factory defaults.
So just running an earlier installer, even only to create a portable copy, resets the installed copy's configuration.

Description of user facing changes:

• When the installer can't load the configuration, it uses factory defaults without changing the file.
  The startup message says the configuration could not be loaded, possibly because a newer version of NVDA saved it, instead of saying it has been reset.
• If the user chooses to install that earlier version, the warning about installing an earlier version also says their configuration will be reset to factory defaults.

Description of developer facing changes:

None.

Description of development approach:

• In ConfigManager._initBaseConf, the launcher loads factory defaults without renaming the file when the configuration can't be loaded.
  It loads the defaults before logging the error, because handling a logged error reads the configuration, which is empty while reverting to the saved configuration.
• Other copies, including secure mode on the sign-in screen, still back up the file, so the error isn't reported on every start.
• InstallingOverNewerVersionDialog adds the reset warning when running as the launcher with config.conf.baseConfigError set.
  PortableCopyOverNewerVersionDialog doesn't, as a portable copy has its own configuration.

Testing strategy:

• Unit tests cover the launcher, a normal copy and secure mode loading an invalid configuration, reverting in the launcher, and the warning text.
• Manual testing with this PR's launcher, run in Windows Sandbox with NVDA alpha 58175 installed, and an nvda.ini that fails validation:
  • Exit at the launcher dialog: nvda.ini is unchanged and no backup is created.
  • Continue running: the new message appears, and the file is unchanged after exit.
  • Revert to saved configuration, reset to factory defaults, and save: NVDA keeps working and nothing is written.
  • Create a portable copy: the copy is created and the file is unchanged.
  • Install: the warning includes the reset paragraph. With a valid configuration, it doesn't.
  • Replace a newer portable copy: the warning doesn't include the reset paragraph.
  • --secure, and the installed copy's configuration without --config-path: the file is unchanged.
  • Install and proceed: the installed earlier copy resets the configuration and backs up the original, as the warning says.

Known issues with pull request:

• A normal copy still logs the error before loading factory defaults.
  If its configuration couldn't be backed up at startup, reverting to the saved configuration can leave it without a configuration.
  This predates this PR.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

Created with Claude Opus 5.5 in Claude Code. Reviewed with gpt-6.1-sol.

🤖 Generated with Claude Code