[c9s] Build failure

[sandrobonazzola]

On CentOS Stream 9 the build uses:

================================================================================
 Package                     Arch   Version                     Repo       Size
================================================================================
Installing:
 ovirt-engine-nodejs-modules noarch 2.2.3-1.el9                 copr_base 196 M
Installing dependencies:
 nodejs                      x86_64 1:16.14.0-2.el9~bootstrap   appstream 216 k
 nodejs-libs                 x86_64 1:16.14.0-2.el9~bootstrap   appstream  14 M

Transaction Summary
================================================================================

Build fails with:

++ yarn install --offline --pure-lockfile
yarn install v1.22.11
[1/4] Resolving packages...
[2/4] Fetching packages...
warning url-loader@1.1.2: Invalid bin field for "url-loader".
info fsevents@2.1.3: The platform "linux" is incompatible with this module.
info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.13: The platform "linux" is incompatible with this module.
info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 15.30s.
++ yarn check
yarn check v1.22.11
info fsevents@2.1.3: The platform "linux" is incompatible with this module.
info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.13: The platform "linux" is incompatible with this module.
info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation.
warning "patternfly#bootstrap-datepicker#jquery@>=1.7.1 <4.0.0" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#datatables.net-colreorder-bs#jquery@>=1.7" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#datatables.net-colreorder#jquery@>=1.7" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#datatables.net-select#jquery@>=1.7" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#datatables.net#jquery@>=1.7" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#drmonty-datatables-colvis#jquery@>=1.7.0" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#patternfly-bootstrap-treeview#jquery@^3.4.1" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#bootstrap-switch#jquery@>=1.9.0" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "patternfly#eonasdan-bootstrap-datetimepicker#jquery@^1.8.3 || ^2.0 || ^3.0" could be deduped from "3.6.0" to "jquery@3.6.0"
warning "datatables.net-colreorder-bs#datatables.net-bs#jquery@>=1.7" could be deduped from "3.6.0" to "jquery@3.6.0"
error "patternfly#eonasdan-bootstrap-datetimepicker#jquery" not installed
info Found 10 warnings.
error Found 1 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

[fitiskin]

Maybe switching from yarn check command to --check-files option would help:

NOTE: The command yarn check has been historically buggy and undermaintained and, as such, has been deprecated and will be removed in Yarn 2.0. You should use yarn install --check-files instead.

From:

yarn install --offline --pure-lockfile
yarn check

To:

yarn install --offline --pure-lockfile --check-files

I've tried to do it locally and the error disappeared.

[sandrobonazzola]

Thanks @fitiskin , giving it a try

[sjd78]

@sandrobonazzola, in ovirt-engine-nodejs-modules, the results of the yarn check is ignored and will not be the source of build issues on C9S.

Unfortunately, our ovirt web projects will not currently build on C9S because they are on webpack 4. Webpack 4 uses a crypto hash function that comes from openssl 1.x. On stream 9 only openssl 3.x is provided. See oVirt/ovirt-web-ui#1568 and oVirt/ovirt-web-ui#1563 for more details. The fix is to upgrade to webpack 5.

Last we looked, patternfly-react v3 was not compatible with webpack 5. I don't think cockpit-ovirt is using patterfly-react anywhere, so that is one less thing to worry about.

cc: @sgratch , @rszwajko