Unify logger.conf and the fallback code

[bocekm]

• use logging.Formatter.converter = time.gmtime for both the file config and fallback config to have the same (UTC) time, in both cases
• unify log levels, using the fallback as the ones to use also in the conf file

[centos-ci]

Can one of the admins verify this patch?

[leapp-bot]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged.

If you want to re-run tests or request review, you can use following commands as a comment:

• leapp-ci build to run unit tests and copr build
• e2e tests to run unit tests, copr build and end-to-end tests (OAMG members only)
• review please to notify leapp developers of review request

[zhukovgreen]

there is a special docstring syntax for the definition of what being raised:

@@ -151,8 +151,7 @@ def run(args, split=False, callback_raw=_console_logging_handler, callback_lineb
     """
     Run a command and return its result as a dict.
 
-    The execution of the command and its result is captured by the audit. The CalledProcessError is raised when
-    the command exits with non-zero code.
+    The execution of the command and its result is captured by the audit.
 
     :param args: Command to execute
     :type args: list or tuple
@@ -168,6 +167,8 @@ def run(args, split=False, callback_raw=_console_logging_handler, callback_lineb
     :type stdin: int, str
     :return: {'stdout' : stdout, 'stderr': stderr, 'signal': signal, 'exit_code': exit_code, 'pid': pid}
     :rtype: dict
+    :raises:
+        CalledProcessError: if the command exits with non-zero status
     """
     if not args:
         message = 'Command to call is missing.'

[zhukovgreen]

No need to put sys.stderr, it is by default

[zhukovgreen]

Should be on the same line with """ (https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings)

[zhukovgreen]

Please don't do this. This is a global state of all loggers. What about the one from the cookbook? (https://docs.python.org/3/howto/logging-cookbook.html#formatting-times-using-utc-gmt-via-configuration)
this could be solved something similar to:

diff --git a/etc/leapp/logger.conf b/etc/leapp/logger.conf
index ee1cf91..66102c4 100644
--- a/etc/leapp/logger.conf
+++ b/etc/leapp/logger.conf
@@ -10,7 +10,7 @@ keys=leapp_audit,stream
 [formatter_leapp]
 format=%(asctime)s.%(msecs)-3d %(levelname)-8s PID: %(process)d %(name)s: %(message)s
 datefmt=%Y-%m-%d %H:%M:%S
-class=logging.Formatter
+class=leapp.logger.UTCFormatter
 
 [logger_urllib3]
 level=WARN

[zhukovgreen]

I think fo ruser would be convininent to see that this time is UTC time

Suggested change

	log_format = '%(asctime)s.%(msecs)-3d %(levelname)-8s PID: %(process)d %(name)s: %(message)s'
	log_format = '%(asctime)s.%(msecs)-3d UTC %(levelname)-8s PID: %(process)d %(name)s: %(message)s'

[fernflower]

@oamg/developers Do we still want this? I'd rather close and reopen on demand.