fix(node): bind performance to support node 19+#101
Merged
oblador merged 1 commit intooblador:masterfrom Oct 12, 2023
mhassan1:bind-performance
Merged
fix(node): bind performance to support node 19+#101oblador merged 1 commit intooblador:masterfrom mhassan1:bind-performance
performance to support node 19+#101oblador merged 1 commit intooblador:masterfrom
mhassan1:bind-performance
Conversation
oblador
approved these changes
Oct 12, 2023
Owner
|
Thanks for quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Node.js wrapper in
isomorphic-performanceto work in Node.js 19+, which added brand checks onperformancein nodejs/node#44483.Resolves #100.