Skip to content

subagent-driven-development: "run review-package from this skill's directory" points git at the plugin cache, not the project #2525

Open

Description

@anchore-jesset

skills/subagent-driven-development/SKILL.md (v6.4.1, and the same wording on main, line 290) tells the controller to run bash scripts/review-package PLAN_FILE BASE HEAD "from this skill's directory". review-package runs git rev-parse, git merge-base and git diff in the current directory and checks [ -f "$plan" ] relative to it. Run from the skill's directory, which for an installed plugin is the plugin cache, it does one of two things:

  • it checks the plugin's own checkout (marketplace installs are git clones), so the project's BASE/HEAD fail with bad BASE: <sha>, or it diffs the wrong repo, and
  • a relative PLAN_FILE such as docs/plans/x.md fails with no such plan file.

The same pattern is at lines 317, 396, 448 and 463.

Suggested fix: keep the project worktree as the working directory and call the helper by its absolute path, e.g. "run bash <this skill's directory>/scripts/review-package PLAN_FILE BASE HEAD from the project worktree". The script already finds its sibling sdd-workspace through dirname "$0", so nothing else needs to change.

Activity

  1. official-rex commented on Oct 15, 2026

    @official-rex

    Allow me to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentationissue-template-rules-ignoredIssue filed after template was added but didn't use itskill:subagent-driven-developmentThe subagent-driven-development skill

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions