Repository navigation
fix(sdd): preserve shared plan constraints in task briefs - #2629
Open
tugrulguner wants to merge 1 commit into
Open
tugrulguner wants to merge 1 commit into
tugrulguner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**Spec:**reference,Global Constraints, andReview Focusin every single-file-plan task brief.task-startconsumer, and register them in the existing test runner.Closes #2493.
Who is submitting this PR?
gpt-6.1-solviaopenai-codexbf0203a794a0Human instruction, verbatim: “continue with superpowers then”.
This is an agent-authored fix for another reporter's issue. No maintainer invitation has been received. Those upstream acceptance requirements remain unmet; they are not represented as satisfied by technical testing or the user's submission instruction.
Human-authored summary
Not provided. The technical summary above and this PR body are agent-written, not human-authored.
What problem are you trying to solve?
#2493 documents a mismatch between
writing-plansand the brief handed to an implementer: the plan says its Global Constraints apply to every task, buttask-briefemits only the numbered task block. The same loss occurs throughexecuting-plans/scripts/task-start. A fresh or compacted executor reading only its brief cannot see requirements such as formal Spanish copy, a Node version floor, or a ban on new runtime dependencies.This contribution is grounded in a deterministic reproduction of the reporter's example, not a claimed firsthand user session. Against unchanged
devatb58deb3b948d4c305feeac122700100419ee2777, the new suite produces 2 passed, 11 failed because the shared sections/spec reference are absent. With this fix it produces 13 passed, 0 failed.What does this PR change?
Buffer the relevant pre-task plan metadata in the existing awk extraction pass and emit it once, immediately before the requested task. Section boundaries use heading depth so nested headings remain part of their parent section; CRLF comparisons and closing ATX markers are recognized without rewriting section content. Missing tasks still return exit 3 rather than succeeding with a header-only output.
No skill instructions, model selection, dispatch recipe, workspace naming, or script stdout interfaces are changed.
Is this change appropriate for the core library?
Yes. This repairs the existing shared plan-to-task handoff used by both SDD and inline execution, across project types. It introduces no dependencies or third-party integration.
What alternatives did you consider?
task-startand fresh/compacted inline execution dependent on remembering another step.00-header.mdfor its new directory path, but leaves the existing single-file awk path unchanged. This patch is limited to that existing path and does not compete with the directory-plan implementation.Does this PR contain multiple unrelated changes?
No. One extraction defect, its regression suite, and a one-line registration in the existing runner. The known atomic-output and broader task-heading/fence-parser issues are not bundled into this change.
Existing PRs
global constraints,review focus, andtask-briefvariants.Environments tested
Commands executed successfully:
The new suite checks shared metadata on early/later tasks, nested sections, CRLF, closing ATX markers, fenced examples, task-local isolation, unchanged legacy extraction, missing-task failure, explicit output paths with spaces, and real
task-startoutput/BASE behavior.New harness support
Not applicable: no harness added or changed.
Evaluation
Rigor
SKILL.mdcontent changed.Human review
This remains unchecked because that review has not been confirmed. Independent technical agent review is not a substitute for human review.