Repository navigation
fix(sdd): keep workspace resolvable when plan file is deleted in a task (#2630) - #2639
Open
bhedanikhilkumar-code wants to merge 1 commit into
Open
bhedanikhilkumar-code wants to merge 1 commit into
bhedanikhilkumar-code wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
What your human partner asked you to do, in their words:
Human-authored summary (required, under 200 words)
When executing plans with subagent-driven-development, finishing tasks often delete or archive the plan file as part of finalizing the branch. Currently,
sdd-workspaceandreview-packageunconditionally require[ -f "$plan" ], causing later steps—such as task review of that final commit and whole-branch review (review-package)—to exit 2 withno such plan file. This PR allowssdd-workspaceandreview-packageto resolve an existing workspace if the plan was tracked in Git history or was already claimed by an existing workspace, while still rejecting truly non-existent plan files with exit 2. All 27 regression tests intest-sdd-workspace.shpass.What problem are you trying to solve?
Fixes #2630.
In
subagent-driven-development, if a task deletes or moves the plan file (e.g.git rm docs/superpowers/plans/<plan>.mdin a finishing commit), subsequent helper invocations fail:sdd-workspaceimmediately exits 2 withno such plan file: <plan>.review-packagefails to generate the diff package for the final task or whole-branch review.Reproduced with Git Bash on Windows / Linux: running
review-packageafter a task deleteddocs/plan.mdexited 2 withno such plan file: docs/plan.md.What does this PR change?
skills/subagent-driven-development/scripts/sdd-workspace: If the plan file is missing from the working tree, checks whether the plan was previously tracked in Git (git rev-list) or already owns an existing workspace in.superpowers/sdd/. If verified, it continues resolution; otherwise, it exits 2 withno such plan file.skills/subagent-driven-development/scripts/review-package: If the plan file is missing from the working tree, delegates verification tosdd-workspace "$plan"before rejecting.tests/claude-code/test-sdd-workspace.sh: Adds regression tests verifying thatsdd-workspaceresolves andreview-packagegenerates diffs even after a commit deletes the plan file.Is this change appropriate for the core library?
Yes. It addresses a real failure mode in core SDD helper scripts affecting all harnesses when tasks clean up plan files. No dependencies added.
What alternatives did you consider?
.superpowers/sdd/: Rejected because checking existing markers and Git history is completely self-contained and requires no extra configuration or files.Does this PR contain multiple unrelated changes?
No. Focused entirely on Issue #2630.
Existing PRs
Environments tested
New harness support (required if this PR adds a new harness)
Not applicable.
Evaluation
bash tests/claude-code/test-sdd-workspace.shand reproduction test scripts.sdd-workspaceto exit 2 withno such plan file.review-packagefailed with exit 2.sdd-workspacecleanly resolves the existing workspace path.review-packagegenerates the review package diff.tests/claude-code/test-sdd-workspace.shpass.Rigor
Human review