Axes and grids now support the filter option

[Fil]

The data for the axis and grid marks (the associated scale’s ticks) is computed (in the general case) after the scales have been initialized. As a consequence,

1. These marks did not support the filter option.
2. The sort and reverse option crashed as the mark’s data is undefined.

In this PR, by moving the filter logic to their initializer function, we allow the user to filter the axis ticks; for example in usStatePopulationDiverging, to draw ticks on the right only for states with a population decrease, and on the left only for states with a population increase. We also throw a proper error message when the sort and reverse options are specified.

closes #1457
closes #1655

[Fil]

Got side tracked by a typescript issue: I want to remove the first and last ticks of an x axis (as in this D3 horizon chart), and for this I use the third argument ticks that the filter function is getting:

Plot.axisX({filter: (tick, index, ticks) => index > 0 && index < ticks.length - 1})

It works; however it's not documented: the function is typed as ((d: any, i: number) => any) // function of data

EDIT: this secondary remark is now addressed in #1670

[mbostock]

@Fil Sounds related to #1640.

[Fil]

the secondary remark is discussed in #1670 and is not blocking for this PR.

[Fil]

rebased

[mbostock]

Any context on what the problem was/what you had to change to get it working?

[Fil]

The PR’s description is now a bit more explicit.

[mbostock]

Thanks for the context. It also helped to hide the whitespace in the diff.

Could we also support sort and reverse by applying them after the axis initializer, like we do for filter? Couldn’t we compose them using the same strategy that the initializer does, just after the axis initializer instead of before? Something like this…

i.initializer = composeInitializer(i.initializer, initializer({filter, sort, reverse}).initializer);

or even shorter

i.initializer = initializer({filter, sort, reverse}, i.initializer).initializer;